Templot5 pdf_laz_unit Completed

[Steve_Cornford]

check datestamp_label compliancy
check ParentFont form settings

Steve

 

[Steve_Cornford]

Hi Martin,
As part of testing the pdf_laz_unit form, I invoked an Export to Pdf, but once the pdf_laz_unit form was displayed i clicked on the [cancel] button/panel.

This screen was displayed:-

and when I clicked ok, just got the rotating circle (egg timer in old money) and when clicking on the [x] to close Templot5 got the "program not responding" etc screen.

I dont think it was anything I had done in the pdf_laz_unit.pas file.

If I [print all] etc it works & produces the PDF as we have tested before.

Steve

 

[Martin Wynne]

Hi Martin,
As part of testing the pdf_laz_unit form, I invoked an Export to Pdf, but once the pdf_laz_unit form was displayed i clicked on the [cancel] button/panel.

This screen was displayed:-
View attachment 10270

and when I clicked ok, just got the rotating circle (egg timer in old money) and when clicking on the [x] to close Templot5 got the "program not responding" etc screen.

I dont think it was anything I had done in the pdf_laz_unit.pas file.

If I [print all] etc it works & produces the PDF as we have tested before.

Steve

@Steve_Cornford

Hi Steve,

I know about that, it's unfinished work. It needs a change to pdf_creator.exe to fail more gracefully, and a flag back to Templot5 that it has done so. I will get back on to it soon. I was mainly concerned to know that it works if you don't click cancel.

Templot would have responded after 2 minutes. There is delay loop while the creator works, see line 305.

That 2-minute cut-off needs to be calculated from the number of pages converting, clearly it is not going to take 2 minutes for just a couple of pages. But potentially there could be 858 pages maximum. (33 x 26)

There is so much unfinished stuff.

cheers,

Martin.

 

[Steve_Cornford]

Ok no problem, as long as you are aware of it.



I have gleaned code 480..499 relate to chairs.
or possibly not!

I will commit pdf_laz_unit changes then
Steve

 

[Martin Wynne]

@Steve_Cornford

Hi Steve,

I have received your pull requests #9 and #10, but I can't do anything with them because they both include the output settings commit, and the reversion of the output settings commit. I haven't yet done the merge for the output settings, and I feel sure it will go wrong if I try to commit something and revert it at the same time.

I can simply Close them, you don't need to do anything. Then send fresh requests. I think it would be better to have a separate pull request for each form, i.e. just the pas and lfm commits in each request, if that's possible.

There is an option to cherry-pick which commits in a pull request are wanted, but I can't make it work according to the instructions.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,
I think all you need to do is take copies of the printer_settings.pas and .lfm files in your local hithub/templot5 folder, then approve the pull requests.
I am fairly sure that the Inclueded two commits relating to print_settings will have a null effect apart from the date of file.
After that you coimd perform a wi merge comparison to prove it.

Then if all ok forget your backup copies else copy them back to your local github folder & perform your own commit.
Steve

 

[Steve_Cornford]

Either way it would be good to find out that that a commit & a revert cancel each other out.
Steve

 

[Martin Wynne]

@Steve_Cornford

That seems to have worked. It wouldn't let me re-open #8 and #9 closed pull requests, claiming that the same commits were in #10 which was still open. So I merged #10 and then fetched in GitHub Desktop, and now all 3 locations contain the same files -- my Lazarus working folder, my Git Templot5 folder, and my cloned Git OT2024 folder.

You should be able to fetch them and see the same?

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,
Yes , I selected my fork, then performed a sync which adviced me to update my branch, which i did.
Then in my GD, i fetched origin, so we are all up to date & matching.
Phew!

Steve