Templot5 - progress discussions

[Martin Wynne]

And I've been distracted from the EMF WIP by John's request for an STL created on T5 -- to get the new end web options and improved brim fence. I've just fixed the bug in the socket conflict function (dxf_unit).

Now I need to look at the Neptune 4 printer config to switch off the auto-levelling fade-out for James.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,

created pull request for trackbed_unit.pas & trackbed_unit.lfm

PLease note that trackbed_unit has a bug which is also in Templot2

Switch on a trackbed edge line.
the trackbed edge line is drawn matching the length of the template
press the [position and length..] and the length comes up as [-0.1] and you get:-

But if before clicking on that button you ckick on the mouse [length] button, all is well

The same bug is also in platform_unit.


I have not solved the bug, just noting it!

Steve

 

[Martin Wynne]

I @Steve_Cornford

Hi Steve,

Thanks for the PR. And thanks for finding the bug -- in fact 2 bugs.

However there was a reason for not setting the platform length to the full template length. The exit road might be adjusted back, and there could be a conflict with a full length platform. For a neat result the platforms need to match the actual rail lengths:

The second bug was that the turnout side was being set to the same length as the main side, when it might need to differ:

Here's the fix -- I haven't done the trackbed yet:

I will push this to GitHub and we will see how it copes with 2 changes to the same part of the same file.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,
Thanks for fixing the real bugs. I had a thought that I was only curing the symptom of the negative length.

Just created pull request for rail_options_unit cosmetic changes etc as commissioned.

Steve

ps whats next?

 

[Martin Wynne]

ps whats next?

A boiled egg?

 

[Martin Wynne]

ps whats next?

Hi Steve,

I will push this now -- maybe you could do the trackbed to match? And test that it is all now working ok.

cheers,

Martin.

 

[Steve_Cornford]

Just had half a fish bap (well fresh sea bream in a ciabatta actually) for lunch.

ok will apply change to trackbed_unit
Steve

 

[Martin Wynne]

@Steve_Cornford

Hi Steve,

Pushed platforms.

Well that was a muddle -- various messages from GitHub about conflicts needing to be resolved before merging. But clear as mud how I was intended to do this "resolving". It would have been 10 times easier to do it myself in WinMerge without letting Git anywhere near it.

But you should be able to fetch it now.

Presumably I should have rejected your mod before pushing my own. But in that case how do I get to see the details of your mod?

Thanks for the rail_options -- looks good.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,
I did apply yuor changes to trackbed_unit.pas and pushed to my fork.
Then when I checked the repository it said my for was 3 commits ahead & 2 commits behind.
I synced my fork, adn now it is saying my fork is uptodate.
But i did not create a pull request for you for trackbed_unit as it seemd that your copy already has the MW changes that I applied to my copy.
Does that mean that you have already applied the changes?

If not is your lazarus copy up to date?

puzzled
Steve

 

[Steve_Cornford]

As long as platform_unit, trackbed_unit and rail_options_unit are all working to your satisfaction, that is all that matters.

I can always delete my fork & recreate it from your main copy if we get in a muddle.

You might want to perform an audit to see what is left to do (apart from your EMF WIP) & point me in the right direction.

Time for a tea & cake break now.

Steve

 

[Martin Wynne]

Hi Martin,
I did apply yuor changes to trackbed_unit.pas and pushed to my fork.
Then when I checked the repository it said my for was 3 commits ahead & 2 commits behind.
I synced my fork, adn now it is saying my fork is uptodate.
But i did not create a pull request for you for trackbed_unit as it seemd that your copy already has the MW changes that I applied to my copy.
Does that mean that you have already applied the changes?

If not is your lazarus copy up to date?

puzzled
Steve

@Steve_Cornford

Hi Steve,

i haven't yet done anything to the trackbed unit, or even looked at it. I haven't yet looked at your rail options either. I need a cup of tea before I go any further. I'm in the middle of measuring chairs and possibly making a change to the default socket sizes for Klipper. John is waiting for his STL files. And James will want to test them too on his new Neptune 4.

cheers,

Martin.

 

[Steve_Cornford]

How strange.
When I look on the GitHub online repository, the copy of trackbed_unit in your repository (updated 23 minutes ago) matches the one in my repository!
ie it has the changes marked MW that I applied (on your behalf) to match the changes you posted for platform_unit.

I will make a cosmetic change & upload again.

Wtach this space.
Steve

 

[Steve_Cornford]

Hi Martin,
There is now a Pull Request for you to action.
it includes a trivial SC comment change ( but also includes the addition of your MW changes for default length calculation)

Please process when convenient.
Steve

 

[Martin Wynne]

Hi Steve,

Well this is new -- I got an email saying that you had pushed something. When I clicked the link I could see it before doing anything about it:

https://github.com/Martin-Wynne/Templot5/commit/2064f3e110d164843659ab3bdb901c4c5af64eeb

That hasn't happened before.

Then I got a separate email about your pull request which I have now merged.

Now I'm going to look in AJC Active Backup to see which of my files have been changed without my knowledge or even being told.

cheers,

Martin.

 

[Martin Wynne]

Here we go -- changed at 16:25 and again at 16:28 :

Shouldn't I get some notification when my files change? And why did it change twice?

Anyway, now to copy it into my Lazarus working folder and have a look.

Martin.

 

[Steve_Cornford]

Hi Martin.
Sometime between 16:18 and 16:51 you did something on Github as you posted on here about it.

It is all a mystery to me too.

When you get a pill request is ther not an optio somewhere for you to actually review the change that is being pull requested?
I assume that for any changes to happen tour your local github you need to go online to the github repository & approve a pull request.



Perhaps when we both have time we could do a zoom session & go through the processes together?


Or perhaps we could keep a manual record of times that we access the online github repository.

Let's look at the positives, which I believe are that we are making steady progress towards the release of a usable Templot5.

I can understand that we have had to contend with the (to us) quirks of Lazarus IDE, but I suspect that with 40 years of Delphi behind you there have been similar obstacles to overcome.




on another note, have you celebrated your birthday yet?

Steve

 

[Martin Wynne]

Hi Martin.
Sometime between 16:18 and 16:51 you did something on Github as you posted on here about it.

It is all a mystery to me too.

When you get a pill request is ther not an optio somewhere for you to actually review the change that is being pull requested?
I assume that for any changes to happen tour your local github you need to go online to the github repository & approve a pull request.



Perhaps when we both have time we could do a zoom session & go through the processes together?


Or perhaps we could keep a manual record of times that we access the online github repository.

Let's look at the positives, which I believe are that we are making steady progress towards the release of a usable Templot5.

I can understand that we have had to contend with the (to us) quirks of Lazarus IDE, but I suspect that with 40 years of Delphi behind you there have been similar obstacles to overcome.




on another note, have you celebrated your birthday yet?

Steve

@Steve_Cornford

Hi Steve,

All is now fine and working. Running in Lazarus and looking good. Thanks for your help.

What I have learned however is -- don't try to do a single thing with any files while Lazarus is open. Close it down completely to move files around or update them. I found some reports online of Lazarus funnies if you try to update files, it seems to keep a cache of old file versions, even if not open in the editor. I found that if opened in Notepad++ a file can contain one thing, and when opened in Lazarus the very same file can contain something else. I couldn't believe this at first, but double-checked twice that I wasn't seeing things.

With the most recent pull request from you something different happened. I got 2 emails instead of 1. The first contained a link showing me your file changes. The second was the usual one with a link to GitHub to merge the request. This made it much easier to know what I was doing. Previously I only ever got the second one. Maybe GitHub has done an update today?

Now running some test files on the Neptune 4, using STLs from Templot5.

Yes, I'm now a year older. Now into the 4th quarter of a century. Where did the first 3 go?

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,

Is it ok for me to have a go at the cosmetic updates for grid_unit.lfm & grid_unit.pas?

Steve

 

[Martin Wynne]

Hi Martin,

Is it ok for me to have a go at the cosmetic updates for grid_unit.lfm & grid_unit.pas?

Steve

Hi Steve,

Yes carry on -- that form looks as if a bomb hit it!

I do have some changes in grid_unit.pas for the screen picture shapes, but not ready to push them yet. Provided we don't try to push things at the same time it should be ok. I will wait until you are all done and finished.

cheers,

Martin.

 

[Steve_Cornford]

Jolly good, there are 10 Tgroupbox objects to convert!

I have converted all 10 to Tpanel, but only applied the cosmetic change (ie add Tlabel & blank caption, plus border changes to 1 so far .

then will adjust size around the hide box.
Will keep you posted.
Steve

 

[Martin Wynne]

Wow! that was quick!

Looking much better.

Martin.

 

[Steve_Cornford]

notepad++ search ; replace before saving & exiting, then desktop 125%, before lazarus ide form manipulation, untick all the parent font boxes, then add labels update borders.
Just a matter of getting into a routine.
Just wish there was an undo button in form update!

Steve

 

[Martin Wynne]

Just wish there was an undo button in form update!

Hi Steve,

CTRL+Z works to undo changes when editing a form. Can go back several steps, I don't know how many.

Lazarus has its own Find in Files, and Replace in the Search menu. Quicker than going into Notepad++ every time.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,

horses for courses.

Thank for the info

pull request created

Steve

 

[Phil O]

A belated Happy 80th Birthday, Martin.

Good work on Templot 5 , both you and Steve, I'm following avidly, but don't understand any of it.

 

[Hayfield]

Martin

Happy birthday

 

[Martin Wynne]

A belated Happy 80th Birthday, Martin.

@Phil O @Hayfield

Thanks Phil, John, but I'm not quite there yet. I turned 76 recently.

Hopefully we can get plug track all done by the time I'm 80 -- now with great help from others.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,

Metric_unit done & pull request created

also fixed the up/down scaling bug by setting autoscroll = true.

By the way I notice on the dummy vehicles form that there is a green Tshape connecting the dummy_vehicles group and the dummy_vehicles_copies group.
Is that intentional to show that they are related?

Steve

 

[Martin Wynne]

By the way I notice on the dummy vehicles form that there is a green Tshape connecting the dummy_vehicles group and the dummy_vehicles_copies group.
Is that intentional to show that they are related?

@Steve_Cornford

Hi Steve,

Yes. There are no radio* buttons in the copies panel, so those buttons could all be in the vehicles panel if you can re-arrange everything to make room! But it's probably best to keep to the Templot2 design for now.

Generally I have tried to pack everything into the smallest dialogs possible, to keep screen space clear for the track plan. There is plenty of scope for re-design in the long term. For example the dummy vehicle and spacing ring settings could ideally be in separate dialogs. Or large dialogs could gain shrink buttons like the info dialog.

*related radio buttons must always be in their own Tpanel or Groupbox.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,
It was just that I suddenly noticed the green shape under the other two panels and tought I had missed yet another groupbox, upon inspection it was just a green Tshape.
Lets leave it for now as it matches Templot2.

Steve

 

[Steve_Cornford]

Hi Martin,
Just finished detail_mode_unit files:-

rather than having the "thick track centre-lines only" radio button cutting the panel outline I have increased the size of the panel.
Then just used the "bring to the front" z-option to have the radio button on top.
All seems to work fine.

If you would rather it remains cutting the panel outline let me know.

I will wait for you to process the previous pull request before creating another one!
Steve

 

[Martin Wynne]

@Steve_Cornford

Hi Steve,

We need our style advisor. To me it would be confusing to have a radio button fully inside a panel linked to one outside it. That's why I had it cutting into the panel outline. This is in T2:

which looks clear to me. But change it if you think it looks wrong.

Now merged your previous pull requests (grid_unit and metric_unit) -- all looking good.

cheers,

Martin.

 

[Steve_Cornford]

Hi Martin,
So like this then:-

Steve

 

[Martin Wynne]

Hi Steve,

Yes, but maybe this would be neater:

(photoshopped, I haven't edited any code)

Martin.

 

[Phil O]

@Phil O @Hayfield

Thanks Phil, John, but I'm not quite there yet. I turned 76 recently.

Hopefully we can get plug track all done by the time I'm 80 -- now with great help from others.

cheers,

Martin.

Sorry, Martin for adding a few more years to your age, me rifmatik wasn't to clever this morning.

 

[Steve_Cornford]

Hi Martin,
done as requested:-

pull request created

Steve

 

[Martin Wynne]

Hi Steve,

Now merged. Looks fine.

Martin.

 

[Steve_Cornford]

Hi Martin,

create_tandem_unit

I left the "groupbox" part of the name of the Tpanel that replaces th Tgroupbox as it is referenced by pad_unit which is your WIP

Pull request created

Steve

 

[Martin Wynne]

@Steve_Cornford

Thanks, now merged.

Martin.

 

[Rob Manchester]

Hi Martin,
Yes, Happy birthday to you. I will set a reminder for your 80th, just keep watching the bus timetables until at least then...........

Rob